From: Thomas Karpiniec <tom.karpiniec@outlook.com>
Date: Thu, 25 Mar 2021 11:34:42 +0000 (+1100)
Subject: Give more friendly error messages if path is not a regular file
X-Git-Tag: v0.2.0~4
X-Git-Url: https://code.octet-stream.net/hashgood/commitdiff_plain/18630e80189942b821fbe5502572acc21bb0543e?ds=sidebyside

Give more friendly error messages if path is not a regular file
---

diff --git a/src/calculate.rs b/src/calculate.rs
index 870115c..dc059b2 100644
--- a/src/calculate.rs
+++ b/src/calculate.rs
@@ -16,12 +16,27 @@ use std::thread::JoinHandle;
 pub type CalculateResult = Result<Vec<(Algorithm, Vec<u8>)>, Box<dyn Error>>;
 
 /// For a given path to the input (may be "-" for STDIN), try to obtain a reader for the data within it.
-pub fn get_input_reader(input: &PathBuf) -> Result<Box<dyn Read>, Box<dyn Error>> {
+pub fn get_input_reader(input: &PathBuf) -> Result<Box<dyn Read>, String> {
     if input.to_str() == Some("-") {
         // Special case: standard input
         return Ok(Box::new(std::io::stdin()));
     }
-    Ok(Box::new(File::open(input)?))
+    if !input.exists() {
+        return Err(format!(
+            "The path '{}' does not exist.",
+            input.to_string_lossy()
+        ));
+    }
+    if !input.is_file() {
+        return Err(format!(
+            "The path '{}' is not a regular file.",
+            input.to_string_lossy()
+        ));
+    }
+    match File::open(input) {
+        Ok(f) => Ok(Box::new(f)),
+        Err(e) => Err(format!("File open: {}", e)),
+    }
 }
 
 /// For the given input stream, calculate all requested digest types