X-Git-Url: https://code.octet-stream.net/netwatcher/blobdiff_plain/d2c9a9f306a336aa9dd8ddfb6579746e4f10b7a4..18f2e52c414d1c98bbca61288b35f8b43cec9f8b:/src/watch_win.rs?ds=inline diff --git a/src/watch_win.rs b/src/watch_win.rs index 23b274e..a247916 100644 --- a/src/watch_win.rs +++ b/src/watch_win.rs @@ -60,17 +60,15 @@ pub(crate) fn watch_interfaces( }; match res { NO_ERROR => { - // Trigger an initial update. - // This is allowed to race with true updates because it - // will always calculate a diff and discard no-ops. - handle_notif(&mut state.lock().unwrap()); + // Trigger an initial update + handle_notif(&mut state.lock().unwrap(), crate::list::list_interfaces()?); // Then return the handle Ok(WatchHandle { hnd, _state: state }) } - ERROR_INVALID_HANDLE => Err(Error::Internal), - ERROR_INVALID_PARAMETER => Err(Error::Internal), - ERROR_NOT_ENOUGH_MEMORY => Err(Error::Internal), - _ => Err(Error::Internal), // TODO: Use FormatMessage and get real error + ERROR_INVALID_HANDLE => Err(Error::InvalidHandle), + ERROR_INVALID_PARAMETER => Err(Error::InvalidParameter), + ERROR_NOT_ENOUGH_MEMORY => Err(Error::NotEnoughMemory), + _ => Err(Error::UnexpectedWindowsResult(res.0)), } } @@ -86,14 +84,14 @@ unsafe extern "system" fn notif( .expect("callback ctx should never be null") .lock() .unwrap(); - handle_notif(state_guard); + let Ok(new_list) = crate::list::list_interfaces() else { + return; + }; + handle_notif(state_guard, new_list); } } -fn handle_notif(state: &mut WatchState) { - let Ok(new_list) = crate::list::list_interfaces() else { - return; - }; +fn handle_notif(state: &mut WatchState, new_list: List) { if new_list == state.prev_list { return; }